Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various small things throughout the codebase #2800

Merged
merged 12 commits into from
Jan 9, 2024
Merged

Fix various small things throughout the codebase #2800

merged 12 commits into from
Jan 9, 2024

Conversation

burgerdev
Copy link
Contributor

Context

While browsing the code base, I stumbled over some minor opportunities that don't justify a dedicated PR each. This is a bulk submission of such findings.

Proposed change(s)

See also individual commits.

  • remove obsolete docs, add fresh docs
  • prettify versionsapi-list output
  • use explicit Helm version in GH action
  • use constants instead of literals
  • check integrity of rekor-cli
  • make rm invocation more robust
  • Minor correctness and simplification tweaks.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Jan 5, 2024
@burgerdev burgerdev added this to the v2.15.0 milestone Jan 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit e02a5fb
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/659d63e7e6a71d00080d9c0a

malt3
malt3 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.github/workflows/build-os-image.yml Outdated Show resolved Hide resolved
3u13r
3u13r approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev force-pushed the burgerdev/minor-fixes branch from f0158a5 to 133af18 Compare January 8, 2024 16:19
@burgerdev burgerdev force-pushed the burgerdev/minor-fixes branch from 133af18 to e02a5fb Compare January 9, 2024 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Coverage report

Package Old New Trend
bootstrapper/cmd/bootstrapper [no test files] [no test files] 🚧
cli/internal/cmd 58.50% 58.50% ↔️
hack/cli-k8s-compatibility [no test files] [no test files] 🚧
image/upload/internal/cmd [no test files] [no test files] 🚧
internal/api/versionsapi/cli [no test files] [no test files] 🚧
internal/attestation/measurements/measurement-generator 0.00% 0.00% 🚧
internal/constellation/helm 53.20% 53.20% ↔️
internal/osimage/measurementsuploader [no test files] [no test files] 🚧

@burgerdev burgerdev removed the request for review from derpsteb January 9, 2024 16:10
@burgerdev burgerdev merged commit ef6f63d into main Jan 9, 2024
10 checks passed
@burgerdev burgerdev deleted the burgerdev/minor-fixes branch January 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@3u13r 3u13r 3u13r approved these changes

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@burgerdev @malt3 @3u13r @daniel-weisse